[PATCH] D35851: [Dominators] Include infinite loops in PostDominatorTree

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: test/CodeGen/ARM/struct-byval-frame-index.ll:7-8
 
 ; We expect the spill to be generated in %if.end230 and the reloads in
 ; %if.end249 and %for.body285.
 
----------------
Remove or update this comment depending on how the checks below end up.


================
Comment at: test/CodeGen/ARM/struct-byval-frame-index.ll:10-12
 ; CHECK: set_stored_macroblock_parameters
-; CHECK: @ %if.end230
-; CHECK-NOT:@ %if.
-; CHECK-NOT:@ %for.
-; CHECK: str r{{.*}}, [sp, [[SLOT:#[0-9]+]]] @ 4-byte Spill
-; CHECK: @ %if.end249
-; CHECK-NOT:@ %if.
-; CHECK-NOT:@ %for.
-; CHECK: ldr r{{.*}}, [sp, [[SLOT]]] @ 4-byte Reload
-; CHECK: @ %for.body285
-; CHECK-NOT:@ %if.
-; CHECK-NOT:@ %for.
-; CHECK: ldr r{{.*}}, [sp, [[SLOT]]] @ 4-byte Reload
+; CHECK: str r{{.*}}, [sp, {{#[0-9]+}}] @ 4-byte Spill
+; CHECK: ldr r{{.*}}, [lr, {{#[0-9]+}}] @ 4-byte Reload
----------------
Is there any way to check that the spill/reload are placed at reasonable places instead of just checking
that they exist at all?

Before the change I made in D34099, the checks looked like

; CHECK: str r{{.*}}, [sp, [[SLOT:#[0-9]+]]] @ 4-byte Spill
; CHECK: bl RestoreMVBlock8x8
; CHECK: bl RestoreMVBlock8x8
; CHECK: bl RestoreMVBlock8x8
; CHECK: ldr r{{.*}}, [sp, [[SLOT]]] @ 4-byte Reload

which isn't very picky either, but at least it's something.

(I don't know the testcase at all, I just convinced myself that my change
didn't actually break anything, and then tried to update the testcase to
still check that the spill/reload are generated at some reasonable places)


https://reviews.llvm.org/D35851