[PATCH] D36722: [InlineCost] Simplify the cold attribute handling in inline-cost.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 17:31:48 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:659
+  // should *always* be considered cold.
+  if (Callee.hasFnAttribute(Attribute::Cold))
+    return true;
----------------
IIRC, static branch prediction already handles this case. Do you see missing cases?


https://reviews.llvm.org/D36722





More information about the llvm-commits mailing list