[PATCH] D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets

[Oleg Ranevskyy via Phabricator via llvm-commits]

iid_iunknown added a comment.

Thanks for the feedback, Peter!

> Is it worth making the macro name less generic

Good point. I will update the patch.

> I haven't managed to find an existing test case that explicitly calls aeabi_fcmp and aeabi_dcmp for a hard float target.

This problem was caught using the standard compiler-rt test suite :) The tests are `test/builtins/Unit/arm/aeabi_cfcmpeq_test.c` and `test/builtins/Unit/arm/aeabi_cdcmpeq_test.c`.
For `aeabi_cfcmpeq_test.c` the call sequence looks like this:

  test -> __aeabi_cfcmpeq -> __aeabi_cfcmple -> __aeabi_fcmpeq -> __eqsf2

However, I can't find an LLVM buildbot that builds and runs the compiler-rt tests for ARM.


Repository:
  rL LLVM

https://reviews.llvm.org/D36675