[PATCH] D36710: [InlineCost] NFC - refactor the checks for different analyses to be a bit more localized to the code that uses those analyses.
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 14 14:20:05 PDT 2017
chandlerc added a comment.
In https://reviews.llvm.org/D36710#841361, @eraman wrote:
> LGTM
Thanks!
> This is not strictly NFC since the entire hot/cold threshold update code used to be guarded by if (PSI) even though PSI is not needed for local hot/cold callsite updates, but practically all the callers within LLVM does pass a non-null PSI.
Yeah, I'll rewrite the description to make more sense.
This is important as there is actually a test change required because it has BFI but not PSI and it makes a difference.
https://reviews.llvm.org/D36710
More information about the llvm-commits
mailing list