[PATCH] D36369: [LLVM][x86][Inline Asm] support for GCC style inline asm - Y<x> constraints

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:36073
+      case '0':
+        if ((type->getPrimitiveSizeInBits() == 128) && Subtarget.hasSSE1())
+          return CW_SpecificReg;
----------------
You need to insert `LLVM_FALLTHROUGH;` after each of these `if / return` cases if you actually want to fall through and to satisfy -Wimplicit-fallthrough. Consider recompiling just this file with the warning enabled.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:36087
+      case '2':
+        LLVM_FALLTHROUGH;
     }
----------------
This is equivalent to `break`.


Repository:
  rL LLVM

https://reviews.llvm.org/D36369