[PATCH] D36671: debuginfo: Improve line info when translating a CaseBlock to SDNodes

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

otherwise this changes looks reasonable to me.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:241
 
+    // DL - the debug location of the instruction this CaseBlock was
+    // produced from.
----------------
FYI, the preferred way of marking up this comment would be
`/// The debug location ...`


================
Comment at: llvm/test/CodeGen/X86/debugloc-no-line-0.ll:1
+; RUN: llc -O0 -mtriple=x86_64-unknown-linux-gnu -o - %s | FileCheck %s
+define i32 @main() !dbg !12 {
----------------
rather than compiling all the way down to assembler, could this be done with -stop (e.g. -stop-before-regalloc or -stop-after-livedebugvariables) so the test case becomes less fragile?


Repository:
  rL LLVM

https://reviews.llvm.org/D36671