[PATCH] D36596: [InstCombine] Don't convert all dbg.declares to dbg.values

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 10:08:17 PDT 2017


rnk added a comment.

I think I forgot to write my conclusion, i.e. what we should do with this patch. :)

I think this patch is an incremental step towards what I sketched out. In the long run, the frontend wouldn't emit dbg.declare, it would emit dbg.value+DW_OP_deref. We would never call LowerDbgDeclare. Passes that remove stores would use utilities similar to salvageDebugInfo and ConvertDebugDeclareToDebugValue to insert dbg.values when deleting stores.


https://reviews.llvm.org/D36596





More information about the llvm-commits mailing list