[PATCH] D36636: [GISel][NFC]: Add some constructors for easy creation of MIRBuilders

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 09:29:42 PDT 2017


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.
One nit below.



================
Comment at: include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:92
+  MachineIRBuilder(MachineInstr &MI) {
+    setMF(*MI.getParent()->getParent());
+    setInstr(MI);
----------------
I would rather call the MachineIRBuilder(MF) constructor.


https://reviews.llvm.org/D36636





More information about the llvm-commits mailing list