[PATCH] D36648: [PGO] Add support for profile dumping dir relocation
Rong Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 14 09:08:34 PDT 2017
xur added a comment.
Lgtm.
================
Comment at: lib/profile/InstrProfilingFile.c:524
PNS = PNS_environment;
+ parseAndSetFilename(SelectedPat, PNS, 0);
} else if (hasCommandLineOverrider) {
----------------
Nit: the call is sunk to the branch, why not getting rid of SelectPat and PNS variable?
Also to the third calls.
https://reviews.llvm.org/D36648
More information about the llvm-commits
mailing list