[PATCH] D36304: [lld] [COFF] Add support for aligncomm directives

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: COFF/DriverUtils.cpp:229
+  if (Name.empty() || Align.empty())
+    fatal("/aligncomm: invalid argument: " + S);
+  int V;
----------------
Use error() and return from this function instead of calling fatal.


================
Comment at: COFF/DriverUtils.cpp:232
+  if (Align.getAsInteger(0, V))
+    fatal("/aligncomm: invalid argument: " + S);
+  Config->AlignComm[Name] = std::max(Config->AlignComm[Name], 1 << V);
----------------
Ditto


https://reviews.llvm.org/D36304