[PATCH] D36675: [ARM][Compiler-rt] Fix AEABI builtins to correctly pass arguments to non-AEABI functions on HF targets

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

The code changes look fine to me. I haven't managed to find an existing test case that explicitly calls __aeabi_fcmp and __aeabi_dcmp for a hard float target. Would it be possible to add one so that we can make sure that we catch any future problems?



================
Comment at: lib/builtins/arm/aeabi_dcmp.S:22
+#if defined(COMPILER_RT_ARMHF_TARGET)
+#  define AEABI_ARGS_TO_VFP_ARGS                           \
+        vmov      d0, r0, r1                     SEPARATOR \
----------------
Is it worth making the macro name less generic as it only applies to this specific case, and could clash with a future definition at a higher level scope?


Repository:
  rL LLVM

https://reviews.llvm.org/D36675