[compiler-rt] r310800 - Enable profile on NetBSD
Joerg Sonnenberger via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 14 00:40:54 PDT 2017
On Sun, Aug 13, 2017 at 11:46:07PM -0700, Vedant Kumar via llvm-commits wrote:
> I'm just echoing what I've stated in the review (https://reviews.llvm.org/D36603 <https://reviews.llvm.org/D36603>).
>
> It's not a good idea to commit something that causes test failures. Please fix or revert this.
I disagree with your position on this. While testing new functionality,
a VISIBLE test failure is much easier to deal with than a hidden test
should-fail test case.
Joerg
More information about the llvm-commits
mailing list