[PATCH] D36603: Enable profile on NetBSD

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 13 23:39:29 PDT 2017

vsk added a comment.

In https://reviews.llvm.org/D36603#840139, @krytarowski wrote:

> In https://reviews.llvm.org/D36603#839356, @vsk wrote:
> > I think it would be better to XFAIL the test from the onset so that people reading the source are aware of the issue. That way, if for any reason this can't make its way back on your priority list, the build will remain in good shape.
> This does not affect the build, only one test in both archs.

By 'the build', I meant the compiler-rt test targets on NetBSD machines. As-is, this patch breaks those test targets, and may bewilder users.

> I will be back to corrections later (at least filing problem reports on bugzilla).

If there are known correctness issues with a patch, there's no need to rush it through. Please use more caution. All it takes here is to add an "XFAIL: *netbsd" line to the test.



More information about the llvm-commits mailing list