[PATCH] D36518: [SLPVectorizer] Schedule bundle with different opcodes.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 13 21:40:37 PDT 2017


dtemirbulatov added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/X86/schedul_bundel.ll:28
+; CHECK-NEXT:    [[VECINIT3_I:%.*]] = insertelement <4 x float> [[VECINIT2_I]], float [[ADD7]], i32 3
+; CHECK-NEXT:    ret <4 x float> [[VECINIT3_I]]
+;
----------------
RKSimon wrote:
> This test doesn't seem to be working?
yes, it is working, but the second function gives up better coverage, I am going to remove this one.


================
Comment at: test/Transforms/SLPVectorizer/X86/schedul_bundel.ll:99
+!4 = !{!"omnipotent char", !5, i64 0}
+!5 = !{!""}
----------------
RKSimon wrote:
> You can drop these attributes if you remove the (unnecessary) tbaa tags
ok, thanks.


https://reviews.llvm.org/D36518





More information about the llvm-commits mailing list