[PATCH] D36655: Move SampleProfileLoader pass before all simplification passes.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 13 16:00:37 PDT 2017

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

The code change LGTM.

To David's point, we do have tests that span basic functionality, so I don't really see a problem with testing this?

The thing we typically try to avoid are tests that span a *frontend* and LLVM proper, but it seems like this could be expressed without that by just having some really minimal IR with debug info that simplify-cfg will destroy, and loading a sample profile into that IR....

That said, if David is OK with it, I'd be happy with the test being in a follow-up commit if it will take a while to craft.


More information about the llvm-commits mailing list