[PATCH] D35621: X86 Asm can't work properly with symbolic Scale

coby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 12 11:42:01 PDT 2017

coby added a comment.

In https://reviews.llvm.org/D35621#838847, @avt77 wrote:

> I applied all changes suggested by Coby.

I'm sorry, I guess I haven't been clear: I meant that the suggested code blob at line 1449 is a practical replacement of the entire patch (apart from the added diagnostics).
It seems to pass your added tests, and not to break anything else, Can you verify it answers your cause(s)?


More information about the llvm-commits mailing list