[PATCH] D36592: [BDCE] clear poison generators after turning a value into zero (PR33695, PR34037)

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 12 02:54:36 PDT 2017


nlopes added a comment.

LGTM, with minor comments: missing the CHECK comment above, and missing a test for the assume removal.



================
Comment at: test/Transforms/BDCE/invalidate-assumptions.ll:72
+  %call_result = call i1 @foo(i1 %trunc)
+  %add = add nsw nuw i1 %call_result, 1
+  %mul = mul i1 %trunc, %add
----------------
Missing CHECK comment here.


https://reviews.llvm.org/D36592





More information about the llvm-commits mailing list