[PATCH] D34566: [loop idiom Recognition] support memcpy for multiple consecutive loads and stores

DIVYA SHANMUGHAN via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 14:11:18 PDT 2017

DIVYA added inline comments.

Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:737
+    } else {
+        if (processLoopStoreOfLoopLoad(StorePtr, StoreSize, HeadStore,
+                                     StoreLoadInst, AdjacentStores, StoreEv,
haicheng wrote:
> DIVYA wrote:
> > haicheng wrote:
> > > I think processLoopStoreOfLoopLoad() can refactor with processLoopStridedStore(), then you don't need if...else... here.
> > processLoopStoreOfLoopLoad() function was already present,so I haven't refactored it with  processLoopStridedStore()  in this patch.I can do that in the next patch
> I think you can go ahead.
So should I do it in this patch or next one?


More information about the llvm-commits mailing list