[PATCH] D36581: [DAG] Fix Node Replacement in PromoteIntBinOp

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 13:26:09 PDT 2017


efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1181
+    if (Replace0 && Replace1 && N0.getNode()->isPredecessorOf(N1.getNode())) {
+      std::swap(N0, N1);
+    }
----------------
You need to swap NN0 and NN1, I think?


https://reviews.llvm.org/D36581





More information about the llvm-commits mailing list