[PATCH] D36280: Fix access to undefined weak symbols in pic code
Richard Smith - zygoloid via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 11 12:09:56 PDT 2017
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me. Please consider whether we should take https://reviews.llvm.org/D36604 too.
================
Comment at: lib/Target/X86/X86Subtarget.cpp:115-117
+ if (GV && GV->hasExternalWeakLinkage() &&
+ TM.getCodeModel() == CodeModel::Small && TM.isPositionIndependent() &&
+ ST->isTargetELF())
----------------
Should this also check `is64Bit()`?
https://reviews.llvm.org/D36280
More information about the llvm-commits
mailing list