[PATCH] D36304: [lld] [COFF] Add support for aligncomm directives

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 6 inline comments as done.
mstorsjo added inline comments.


================
Comment at: COFF/Driver.cpp:1178
+    if (auto *DC = dyn_cast<DefinedCommon>(Sym->body())) {
+      if (auto *CC = DC->getChunk())
+        CC->setAlign(1 << Align);
----------------
ruiu wrote:
> Is it possible that getChunk() returns a null?
I'm not sure actually, I did it this way originally just to be extra safe, but I'll remove this if statement for now.


https://reviews.llvm.org/D36304