[PATCH] D36344: [X86] Don't use fsin/fcos/fsincos instructions ever

David Kreitzer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 11:14:52 PDT 2017

DavidKreitzer accepted this revision.
DavidKreitzer added a subscriber: zvi.
DavidKreitzer added a comment.
This revision is now accepted and ready to land.

Adding Zvi as an FYI, but I think this is fine to land.

Comment at: test/CodeGen/X86/sincos-opt.ll:124
+; GNU_SINCOS_FASTMATH: fldt 32(%{{[re]}}sp)
 ; GNU_SINCOS_FASTMATH: faddp %st(1)
   %call = tail call x86_fp80 @sinl(x86_fp80 %x) readnone
craig.topper wrote:
> craig.topper wrote:
> > DavidKreitzer wrote:
> > > Was moving the check for 'ret' here intentional?
> > I think all I did was copy the GNU_SINCOS check lines from above and changed them to say GNU_SINCOS_FASTMATH. I hadn't noticed the difference in the ret.
> Do you want me to add it back or is it ok like this?
As far as I'm concerned it's okay either way.


More information about the llvm-commits mailing list