majnemer added inline comments. ================ Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:94 + } else { + llvm_unreachable("Unable to lowerGlobalAddress"); + } ---------------- Shouldn't this be report_fatal_error ? https://reviews.llvm.org/D29934