[PATCH] D36591: [PredicateInfo] Add a helper routine to remove SSA copies from a Function.

Chad Rosier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 11 05:55:39 PDT 2017

mcrosier added a comment.

In https://reviews.llvm.org/D36591#838798, @davide wrote:

> I'm not necessarily against this, and I think having PI garbage collecting the intrinsics is a good thing.
>  What I'm wondering here if you hit a case  when this actually matters? I and Dan debugged several cases where PI intrinsics weren't reclaimed but those were all legitimate bugs in NewGVN.
>  In case we decide to use PI for some other pass (LVI is an obvious candidate) then having this logic handled in the utility may make things easier.

I have a patch in flight that uses PI along with this routine.  The patch isn't yet in a state to be reviewed, but I figured I'd post this just to make sure I was on the right track w.r.t. cleaning up the ssa copies..  Approval for this can certainly be deferred until I have my WIP in a reviewable state.


More information about the llvm-commits mailing list