[PATCH] D36127: [OptDiag] Updating Remarks in SampleProfile

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:1260
+      ORE->emit(OptimizationRemark(DEBUG_TYPE, "PopularDest", MaxDestInst)
+                << ore::NV("PopularInstruction", MaxDestInst)
+                << " is the most popular destination for conditional branches at "
----------------
Why do you output the instruction?  Its location should already be carried by remark location.  It's also weird to see the instruction name in the remark:

CHECK: remark: nolocinfo.c:3:5: ret is the most popular destination for conditional branches at <UNKNOWN LOCATION>


Repository:
  rL LLVM

https://reviews.llvm.org/D36127