[PATCH] D36581: [DAG] Fix Node Replacement in PromoteIntBinOp

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 16:28:37 PDT 2017

efriedma added a comment.

This is why I hate DAGCombine; you have to constantly worry about the CSE map invalidating pointers you care about, and I'm never confident I'm handling it correctly.

Could we simplify this code using makeEquivalentMemoryOrdering to insert the loads into the right spot in the DAG?  Or does that introduce its own RAUW problems?


More information about the llvm-commits mailing list