[PATCH] D36594: [LLD] Don't install libraries when LLVM_INSTALL_TOOLCHAIN_ONLY is ON

[Rafael Avila de Espindola via llvm-commits]

LGTM from an lld point of view, but I wonder if some of this code can be
refactored to llvm.

Cheers,
Rafael

Eugene Zelenko via Phabricator <reviews at reviews.llvm.org> writes:

> Eugene.Zelenko created this revision.
> Eugene.Zelenko added a project: lld.
> Herald added a subscriber: mgorny.
>
> LLD currently installs libraries without respecting LLVM_INSTALL_TOOLCHAIN_ONLY. Installation depends on LLD_BUILD_TOOLS, but this variable is used in other places, so it could not be defaulted to NOT LLVM_INSTALL_TOOLCHAIN_ONLY.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D36594
>
> Files:
>   cmake/modules/AddLLD.cmake
>
>
> Index: cmake/modules/AddLLD.cmake
> ===================================================================
> --- cmake/modules/AddLLD.cmake
> +++ cmake/modules/AddLLD.cmake
> @@ -10,7 +10,7 @@
>    llvm_add_library(${name} ${ARG_ENABLE_SHARED} ${ARG_UNPARSED_ARGUMENTS})
>    set_target_properties(${name} PROPERTIES FOLDER "lld libraries")
>  
> -  if (LLD_BUILD_TOOLS)
> +  if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLD_BUILD_TOOLS)
>      if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
>          NOT LLVM_DISTRIBUTION_COMPONENTS)
>        set(export_to_lldtargets EXPORT lldTargets)
>
>
> Index: cmake/modules/AddLLD.cmake
> ===================================================================
> --- cmake/modules/AddLLD.cmake
> +++ cmake/modules/AddLLD.cmake
> @@ -10,7 +10,7 @@
>    llvm_add_library(${name} ${ARG_ENABLE_SHARED} ${ARG_UNPARSED_ARGUMENTS})
>    set_target_properties(${name} PROPERTIES FOLDER "lld libraries")
>  
> -  if (LLD_BUILD_TOOLS)
> +  if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY AND LLD_BUILD_TOOLS)
>      if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
>          NOT LLVM_DISTRIBUTION_COMPONENTS)
>        set(export_to_lldtargets EXPORT lldTargets)