[llvm] r310631 - Fix 'not all control paths return' warning on windows builds. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 10:20:09 PDT 2017


Author: rksimon
Date: Thu Aug 10 10:20:09 2017
New Revision: 310631

URL: http://llvm.org/viewvc/llvm-project?rev=310631&view=rev
Log:
Fix 'not all control paths return' warning on windows builds. NFCI.

Modified:
    llvm/trunk/tools/llvm-rc/ResourceScriptToken.cpp

Modified: llvm/trunk/tools/llvm-rc/ResourceScriptToken.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-rc/ResourceScriptToken.cpp?rev=310631&r1=310630&r2=310631&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-rc/ResourceScriptToken.cpp (original)
+++ llvm/trunk/tools/llvm-rc/ResourceScriptToken.cpp Thu Aug 10 10:20:09 2017
@@ -215,9 +215,7 @@ Error Tokenizer::consumeToken(const Kind
     assert(false && "Cannot consume an invalid token.");
   }
 
-  // This silences the compilers which cannot notice that the execution
-  // never reaches here.
-  assert(false);
+  llvm_unreachable("Unknown RCToken::Kind");
 }
 
 bool Tokenizer::willNowRead(StringRef FollowingChars) const {




More information about the llvm-commits mailing list