[PATCH] D36127: [OptDiag] Updating Remarks in SampleProfile

[Adam Nemet via Phabricator via llvm-commits]

anemet added a comment.

In https://reviews.llvm.org/D36127#837621, @anemet wrote:

> In https://reviews.llvm.org/D36127#837482, @tarunr wrote:
>
> > -pass-remarks-with-hotness doesn't seem to be helping me in getting hotness information in these remarks.
>
>
> It does something (after applying your patch):
>
> ./bin/opt -sample-profile -sample-profile-file=../test/Transforms/SampleProfile/Inputs/remarks.prof -S  -pass-remarks-output=- -pass-remarks-with-hotness ../test/Transforms/SampleProfile/remarks.ll -o /dev/null | grep Hotness
>  Hotness:         0
>  Hotness:         0
>
> but the 0 values are probably wrong.  You probably need to study/debug this.  The hotness should come from BFI which sample profiler should be updating.


Actually thinking a bit more about this, I don't think we can expect correct profile counts in BFI at this point.  This pass adds the necessary metadata to get profile count on a subsequent run of BFI.  @davidxl, am I right about this?

So I think for now we should just add a comment about this.


Repository:
  rL LLVM

https://reviews.llvm.org/D36127