[PATCH] D36575: [ARM] Assembler support for the ARMv8.2a dot product instructions

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 09:01:04 PDT 2017


SjoerdMeijer added a comment.

Hi Sam,
Thanks for reviewing. I agree it looks odd, but the argument of not doing this, is that this is not user-facing. I.e., they are internal options and it's Clang's responsibilities to parse options and set the target features. Other optional instructions/extensions are also not predicated on e.g. v8.1a or v8.2a.

Cheers,
Sjoerd.


https://reviews.llvm.org/D36575





More information about the llvm-commits mailing list