[PATCH] D36408: [LV] Minor fixes to Sink casts to unravel first order recurrence

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 08:59:08 PDT 2017

mssimpso added inline comments.

Comment at: lib/Transforms/Utils/LoopUtils.cpp:568
         DT->dominates(Previous, I->user_back())) {
-      SinkAfter[I] = Previous;
+      if (!DT->dominates(Previous, I)) // Otherwise we're good w/o sinking.
+        SinkAfter[I] = Previous;
Is it worth adding a test case for this? I'm not sure...


More information about the llvm-commits mailing list