[PATCH] D36546: Garbage-collect common symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Symbols.h:165
+  // belong to any input section, their liveness is managed by this bit.
+  bool Live;
 
----------------
grimar wrote:
> Should it be `unsigned isLive: 1` ? (for consistency with flags in `SymbolBody`)
> 
No, you don't want to use bitfields unless it is necessary. `bool` is the standard type to represent a true/false variable.


Repository:
  rL LLVM

https://reviews.llvm.org/D36546