[PATCH] D35035: [InstCombine] Prevent memcpy generation for small data size
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 10 08:51:06 PDT 2017
spatel added a comment.
This patch as uploaded makes even less sense to me than before:
1. There are no tests to show the diff.
2. You've changed the code rather than an assertion in an unrelated test to show a functional difference?
I've checked in some extra tests where I think your patch will fire here:
https://reviews.llvm.org/rL310611
Please update this patch to include that and then explain the intent of each diff.
As I mentioned before, you can use a script to update the check lines (please don't hand-edit them):
$ path/to/update_test_checks.py --opt=path/to/build/bin/opt memcpy-to-load.ll
https://reviews.llvm.org/D35035
More information about the llvm-commits
mailing list