[PATCH] D36578: [JSON][PM] Port json import/export over to new pm

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 06:28:59 PDT 2017


philip.pfaffe created this revision.
Herald added a reviewer: bollu.

I pulled out all functionality into static functions, and use those both
in the legacy passes and in the new ones. There is one functional
change: Before, if we fail to parse a jscop file, this will be reported
as an error and importing is aborted. However, this isn't actually
strong enough, since although the import is aborted, the scop has
already been modified and is very likely broken. Instead, make this a
hard failure and throw an LLVM error. This new behaviour requires small
changes to the tests for the legacy pass, namely using `not`.


https://reviews.llvm.org/D36578

Files:
  lib/Exchange/JSONExporter.cpp
  lib/Support/PollyPasses.def
  lib/Support/RegisterPasses.cpp
  test/Isl/CodeGen/MemAccess/bad_alignment.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Bad-relation.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-No-accesses-key.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Not-enough-MemAcc.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Not-enough-statements.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Relation-mispelled.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Statements-mispelled.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Undeclared-ScopArrayInfo.ll
  test/JSONExporter/ImportAccesses/ImportAccesses-Wrong-number-dimensions.ll
  test/JSONExporter/ImportArrays/ImportArrays-Mispelled-type.ll
  test/JSONExporter/ImportArrays/ImportArrays-Negative-size.ll
  test/JSONExporter/ImportArrays/ImportArrays-No-name.ll
  test/JSONExporter/ImportArrays/ImportArrays-No-sizes-key.ll
  test/JSONExporter/ImportArrays/ImportArrays-No-type-key.ll
  test/JSONExporter/ImportContext/ImportContext-Context-mispelled.ll
  test/JSONExporter/ImportContext/ImportContext-Not-parameter-set.ll
  test/JSONExporter/ImportContext/ImportContext-Unvalid-Context.ll
  test/JSONExporter/ImportContext/ImportContext-Wrong-dimension.ll
  test/JSONExporter/ImportSchedule/ImportSchedule-No-schedule-key.ll
  test/JSONExporter/ImportSchedule/ImportSchedule-Schedule-not-valid.ll
  test/JSONExporter/ImportSchedule/ImportSchedule-Statements-mispelled.ll
  test/JSONExporter/ImportSchedule/ImportSchedule-Wrong-number-statements.ll
  test/ScopDetect/base_pointer_load_is_inst_inside_invariant_1___%for.i---%exit.jscop
  test/Simplify/notredundant_region_middle.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36578.110569.patch
Type: text/x-patch
Size: 29023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170810/eead5e1c/attachment.bin>


More information about the llvm-commits mailing list