[PATCH] D36559: [ARM] Clarify legal addressing modes for ARM and Thumb2. NFC
Evgeny Astigeevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 10 05:40:20 PDT 2017
eastig accepted this revision.
eastig added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:12366
+ // r * 2 (this can be lowered to r + r).
+ if (!AM.HasBaseReg && Scale == 2)
return true;
----------------
Agree, this code needs to be reviewed. LDRD has tricky addressing modes for both ARM and T2 modes.
Repository:
rL LLVM
https://reviews.llvm.org/D36559
More information about the llvm-commits
mailing list