[PATCH] D36451: [ELF, LinkerScript] Support ! operator in linker script.

Hafiz Abid Qadeer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 02:02:16 PDT 2017

abidh added inline comments.

Comment at: ELF/ScriptLexer.cpp:215-217
+  // Don't breakup != operator into 2 tokens
+  if (V.size() == 2 && V[0] == "!" && V[1] == "=")
+    return;
ruiu wrote:
> I don't think this is correct. For example, I don't think this can handle expression `0!=1`. You want to add code to tokenizeExpr instead of this function.
I think 0!=1 was failing even without my patch. I have fixed it now and added a test to check it.


More information about the llvm-commits mailing list