[PATCH] D36520: [ELF] - Implemented GC for common symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 10 00:47:52 PDT 2017


grimar abandoned this revision.
grimar added a comment.

In https://reviews.llvm.org/D36520#837109, @ruiu wrote:

> I think this patch needs rewriting because it uses a callback function where you don't actually have to and uses Offset as a different meaning than it should be. I'll send you an updated one.


`Live` bit is the first thing I was thinking of honestly. Then decided to reuse `Offset`, supposed that new field will became a problem during review :)
Abandoning in favor of https://reviews.llvm.org/D36546.


https://reviews.llvm.org/D36520





More information about the llvm-commits mailing list