[PATCH] D36018: Make .file directive to have basename only

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 20:59:40 PDT 2017

It is not necessary, just a LGTM on the list is OK.


Taewook Oh <twoh at fb.com> writes:

> Thanks for the review. Could you please accept it from phabricator as well? Thanks!
> Best,
> Taewook
> From: Peter Collingbourne <peter at pcc.me.uk>
> Date: Wednesday, August 9, 2017 at 6:27 PM
> To: Rafael Avila de Espindola <rafael.espindola at gmail.com>
> Cc: Teresa Johnson <tejohnson at google.com>, Mehdi AMINI <joker.eph at gmail.com>, "reviews+D36018+public+24bc47bb4db179c8 at reviews.llvm.org" <reviews+D36018+public+24bc47bb4db179c8 at reviews.llvm.org>, Taewook Oh via Phabricator <reviews at reviews.llvm.org>, Taewook Oh <twoh at fb.com>, llvm-commits <llvm-commits at lists.llvm.org>
> Subject: Re: [PATCH] D36018: Make .file directive to have basename only
> On Wed, Aug 9, 2017 at 6:19 PM, Rafael Avila de Espindola <rafael.espindola at gmail.com<mailto:rafael.espindola at gmail.com>> wrote:
> Peter Collingbourne <peter at pcc.me.uk<mailto:peter at pcc.me.uk>> writes:
>> ThinLTO uses the source filename to compute GUIDs for globals, so this
>> change will increase the likelihood of GUID collisions.
> Note that this change only the asm printer. Is that the code path that
> is used for computing GUID?
> Apologies, I misunderstood your earlier mail and didn't look at the change itself. The GUID computation is done elsewhere.
> This change LGTM.
> Thanks,
> --
> --
> Peter

More information about the llvm-commits mailing list