[PATCH] D36018: Make .file directive to have basename only

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 18:27:24 PDT 2017

On Wed, Aug 9, 2017 at 6:19 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Peter Collingbourne <peter at pcc.me.uk> writes:
> > ThinLTO uses the source filename to compute GUIDs for globals, so this
> > change will increase the likelihood of GUID collisions.
> Note that this change only the asm printer. Is that the code path that
> is used for computing GUID?

Apologies, I misunderstood your earlier mail and didn't look at the change
itself. The GUID computation is done elsewhere.

This change LGTM.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170809/c3fe6c22/attachment.html>

More information about the llvm-commits mailing list