[PATCH] D36535: [LLD/PDB] Output actual records to the globals stream

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:476
+    return false;
+  // S_GDATA32 does not go in the module stream, but S_LDATA32 does.
+  case SymbolKind::S_LDATA32:
----------------
We don't seem to have test coverage for this. Do you mind adding one? You might be able to modify one of the yaml test cases...


================
Comment at: lld/test/COFF/pdb-comdat.test:57
 CHECK:   196 | S_END [size = 4]
-CHECK:   200 | S_GDATA32 [size = 24] `global`
-CHECK:         type = 0x0074 (int), addr = 0000:0000
----------------
Oh right, these do only go in the globals section. Woops.


https://reviews.llvm.org/D36535