[PATCH] D36552: [LVI] Fix LVI compile time regression around constantFoldUser()

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 16:09:03 PDT 2017

sanjoy added inline comments.

Comment at: lib/Analysis/LazyValueInfo.cpp:1496
+        ValUsesConditionAndFoldable = usesOperand(Usr, Condition) &&
+            canConstantFoldUser(Usr);
+      if (!ValUsesConditionAndFoldable)
Shouldn't this be `canConstantFoldUser(Usr) && usesOperand(Usr, Condition)`?  Otherwise we're not really short-circuiting anything.


More information about the llvm-commits mailing list