[PATCH] D36548: [llvm-dlltool] Fix creating stdcall import libraries for MinGW/i386

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 14:20:37 PDT 2017

martell added a comment.

This is related to what we were talking about earlier on the mingw-w64 mailing list about unifying all def files for all 4 platforms. :)
Maybe we can add i386 to the unified version and add a flag when building mingw-w64 to use that along with using a flag to disable MingwDef.
In general though we do not want MingwDef to exist long term and I did not originally add this because `.def` files should not contain `@4` `@8` etc in the first place.

Although this might not do any harm though if done correctly.
`E.Name.substr(0, E.Name.find('@'));` does not seem like enough because many symbols can have `@` and other special characters.
Can you make sure only a number exists after the `@`?


More information about the llvm-commits mailing list