[PATCH] D36544: [COFF] Add SymbolName as a distinct field in COFFImportFile

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 12:58:38 PDT 2017


rnk added inline comments.


================
Comment at: lib/Object/COFFImportFile.cpp:593
 
-    StringRef SymbolName = E.isWeak() ? E.ExtName : E.Name;
     ImportNameType NameType = getNameType(SymbolName, E.Name, Machine);
----------------
Do we not need to look at ExtName for weak symbols?


https://reviews.llvm.org/D36544





More information about the llvm-commits mailing list