[PATCH] D36535: [LLD/PDB] Output actual records to the globals stream

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
Herald added subscribers: hiraditya, mgorny.

Previously we were just writing an empty globals stream.  I hypothesized that fixing this would fix the last remaining known issue with using WinDbg, which is that we could not display local variables.  Unfortunately this patch only gets us halfway there.  Previously when displaying locals you would get an error message saying that private symbol information could not be found, and running the "lm" command in WinDbg would say that only public symbols were available.  After this patch, the lm command reports that private symbols are present, but attempting to display a local variable still reports the same error.  So there is something else missing.


https://reviews.llvm.org/D36535

Files:
  lld/COFF/PDB.cpp
  llvm/include/llvm/DebugInfo/CodeView/RecordName.h
  llvm/include/llvm/DebugInfo/CodeView/TypeDeserializer.h
  llvm/include/llvm/DebugInfo/CodeView/TypeName.h
  llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h
  llvm/include/llvm/DebugInfo/PDB/Native/GSIStreamBuilder.h
  llvm/lib/DebugInfo/CodeView/CMakeLists.txt
  llvm/lib/DebugInfo/CodeView/LazyRandomTypeCollection.cpp
  llvm/lib/DebugInfo/CodeView/RecordName.cpp
  llvm/lib/DebugInfo/CodeView/TypeName.cpp
  llvm/lib/DebugInfo/CodeView/TypeTableCollection.cpp
  llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36535.110437.patch
Type: text/x-patch
Size: 16065 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170809/0560d027/attachment.bin>