[llvm] r310481 - [ValueTracking] Honour recursion limit.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 10:39:42 PDT 2017


On Wed, Aug 9, 2017 at 9:11 AM, Davide Italiano <davide at freebsd.org> wrote:
> On Wed, Aug 9, 2017 at 8:19 AM, Davide Italiano <davide at freebsd.org> wrote:
>> On Wed, Aug 9, 2017 at 8:13 AM, Davide Italiano via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: davide
>>> Date: Wed Aug  9 08:13:50 2017
>>> New Revision: 310481
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=310481&view=rev
>>> Log:
>>> [ValueTracking] Honour recursion limit.
>>>
>>> The recently improved support for `icmp` in ValueTracking
>>> (r307304) exposes the fact that `isImplied` condition doesn't
>>> really bail out if we hit the recursion limit (and calls
>>> `computeKnownBits` which increases the depth and asserts).
>>>
>>
>> Hans, I think this could be considered as a candidate to be backported
>> to 5 [cc: Petr & Chad].
>>
>
> Also r310492 (which fixes the tests)

Sounds good to me. I'll merge after it's been in trunk a little while.


More information about the llvm-commits mailing list