[PATCH] D35402: [zorg] Enable running 'lnt runtest test-suite' instead of 'lnt runtest nt'.
Kristof Beyls via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 08:40:28 PDT 2017
kristof.beyls marked an inline comment as done.
kristof.beyls added a subscriber: vleschuk.
kristof.beyls added inline comments.
Comment at: zorg/buildbot/builders/ClangBuilder.py:779
+ use_runtest_testsuite = len(nt_flags) == 0
+ if not use_runtest_testsuite:
+ test_suite_cmd = [python, lnt, 'runtest', 'nt',
> Could you throw an error or assert or something to make sure people don't pass in both nt_flags and testsuite_flags?
I tried adding
assert len(nt_flags) == 0 or len(testsuite_flags) == 0
but when you let it trigger by a bot defining both, you get an assertion failure when trying to start up the buildbot master.
That means that Galina or @vleschuk would fail to start the buildbot master if just one slave configuration triggered the assert.
Overall, it feels to me that it's better to not assert on the buildbot master, and put the onus on the bot owners to make sure their bot does what they intend them to do.
More information about the llvm-commits