[PATCH] D35851: [Dominators] Include infinite loops in PostDominatorTree

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 9 08:33:00 PDT 2017

davide added a comment.

I think this patch {c,sh}ould be considered for commit as is.
The reason is twofold:

1. The current postdom behaviour has some known brokeness that caused several bugs. PDSE is just an example, but try to fuzz LLVM and you'll find all this sort of craziness. I've reviewed the original change in January to change this behaviour, which was reverted because you disagreed. I'm afraid that until somebody sits down and implements what you propose (probably you :) the discussion can go on and on indefinitely.
2. I'd say this patch is an improvement on the current state, so I don't think we should hold on forever.


More information about the llvm-commits mailing list