[PATCH] D36499: If --dynamic-list is given, only those symbols are preemptible
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 9 05:13:55 PDT 2017
ruiu added inline comments.
================
Comment at: ELF/Config.h:87
llvm::StringRef DynamicLinker;
+ bool HasDynamicList;
llvm::StringRef Entry;
----------------
These members are sorted by type and then by name, so move below.
================
Comment at: ELF/Driver.cpp:748
+ for (auto *Arg : Args.filtered(OPT_dynamic_list)) {
+ Config->HasDynamicList = true;
if (Optional<MemoryBufferRef> Buffer = readFile(Arg->getValue()))
----------------
Maybe you want to set this only once by `Config->HasDynamicList = Args.hasArg(OPT_dynamic_list)`?
================
Comment at: ELF/Writer.cpp:1185
- for (Symbol *S : Symtab->getSymbols())
- S->body()->IsPreemptible = S->body()->computeIsPreemptible();
+ if (Config->HasDynamicList) {
+ for (SymbolVersion V : Config->VersionScriptGlobals) {
----------------
This needs a comment.
https://reviews.llvm.org/D36499
More information about the llvm-commits
mailing list