[PATCH] D36497: compute isPreemtible only once

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Symbols.cpp:141
 // with the same name defined in other ELF executable or DSO.
-bool SymbolBody::isPreemptible() const {
-  if (isLocal())
-    return false;
-
+bool SymbolBody::computeIsPreemptible() const {
+  assert(!isLocal());
----------------
Is it possible to define this function as a non-member static function? if it is doable, it is preferable, because it makes clear that this function does not depend on private members.


https://reviews.llvm.org/D36497