[PATCH] D36385: [asan] Refactor thread creation bookkeeping

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 8 17:35:50 PDT 2017

vitalybuka added inline comments.

Comment at: lib/asan/asan_thread.cc:290
+                       const_cast<uptr *>(&stack_size),
+                       &tls_begin_, &tls_size);
   stack_top_ = stack_bottom_ + stack_size;
alekseyshl wrote:
> mcgrathr wrote:
> > alekseyshl wrote:
> > > What was wrong with the wrapping here?
> > It was over 79 chars, which makes an Emacs in an 80-chars-wide terminal put a \ at the end.
> > Obviously I don't care about formatting issues, this is just a change I make unconsciously in anything I'm touching.
> It's exactly at 80 chars limit we enforce in sanitizers, please change it back to reduce the unnecessary churn.
"git clang-format --style file -f origin/master" can help


More information about the llvm-commits mailing list